Code Review #1

AR
Model
UI
Up Java Resources C++ Resources .NET Resources DevHood Search
  •  Code freeze from Mon. March 17 through Friday, March 21.

  •  All documentation must be complete by noon, Tuesday, March 18.

 

Code review criteria:

  1. The review of the code should address the following issues:

    1. Flexibility : How well does the code adapt/handle the different scenarios withing its current stated abilities?   Does the code naturally handle its capabilities, or are there lots of "gotcha's" that need to be considered?
    2. Extensibility : How well will the code handle future extensions in capability? How is the program limited by its design?
    3. Correctness : Does the code do what it is supposed to do--does it meet "spec"?Does the code guarantee that the correct result will occur?  Are there valid inputs that result in incorrect behavior? 
    4. Robustness : How well does the code handle incorrect inputs or other error conditions? Note that the code may be spec'd to fail under certain conditions, but ask whether or not that is reasonable or a design flaw.

  2. The code review should also include suggestions for redesign or improvement:

    1. Be specific as to what part of the code should be changed and how, don't just say "fix this part".
    2. Support your suggestions with concrete reasons, don't just say "it will make it better".

 

Tasking

Team Person Code to Review
Model Ryan AR
Model James AR
Model Ali AR
Model Bryan UI
Model Gilbert UI
UI Brian Model
UI Kijana Model
UI Jeff AR
UI Travis AR
AR Will Model
AR Justin Model
AR Theo UI
AR Robby UI

Code review reports are due separately from the journal.    The journal should focus on what happened while working on the code review, not the details of the code review itself.

Put reviews into the HTML pages linked to the left, which can be found in the docs/coderev1 directory.